Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved schema email validation #785

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tobibytes
Copy link

Resolves #775

Description

Added a test case for invalid email validation in the chapter and project directories. It includes:

  • A new leader-email-invalid.yaml file with an invalid email (test@gmail).
  • Updates to chapter_test.py and project_test.py to check for this invalid email and ensure proper error handling.

Motivation

To improve input validation and ensure the system properly handles invalid email addresses.

How Has This Been Tested?

The test cases for invalid emails were executed, and all tests passed successfully.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tobibytes
Thanks for a clean PR!

Please make sure to address the improvement I mentioned in the issue -- we need to validate the email format, but currently it just yells about its length which kind of works, I agree. But I'd like to have a comprehensive solution -- uou need validators.email() for that (see example here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve schema email validation
2 participants