Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrated RateLimiter for request throttling #995

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Aswinr24
Copy link

Proposed change

This PR aims to introduce a fully functional rate limiter to the project, which will control the rate at which requests can be made to avoid overloading resources or violating rate-limiting policies. Also including a cli flag to configure window size and max requests manually

Realted to #727

Type of change

  • New core framework functionality
  • Bugfix (non-breaking change which fixes an issue)
  • Code refactoring without any functionality changes
  • New or existing module/payload change
  • Localization improvement
  • Dependency upgrade
  • Documentation improvement

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@Aswinr24 Aswinr24 marked this pull request as draft January 25, 2025 17:44
@securestep9
Copy link
Collaborator

Nettacker is an asynchronous Python application using aiohttp, so time.sleep() is not the correct way to implement rate limiting because it is a blocking call that will pause the entire event loop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants