Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to Express v5 #1153

Merged
merged 4 commits into from
Dec 27, 2024
Merged

Upgrading to Express v5 #1153

merged 4 commits into from
Dec 27, 2024

Conversation

lreading
Copy link
Collaborator

Summary:
Upgrades Express to version 5.x

Description for the changelog:
Upgrade to Express@5

@lreading lreading self-assigned this Dec 27, 2024
@lreading lreading marked this pull request as draft December 27, 2024 16:54
@lreading lreading requested a review from jgadsden December 27, 2024 17:05
@lreading lreading marked this pull request as ready for review December 27, 2024 17:05
@lreading lreading marked this pull request as draft December 27, 2024 17:09
@lreading lreading removed the request for review from jgadsden December 27, 2024 17:11
@lreading
Copy link
Collaborator Author

Sorry, I tagged you prematurely Jon, still a WIP :)

@lreading
Copy link
Collaborator Author

It looks like version 5 didn't require any changes on our end. Interestingly upgrading in the v4 path had some breaking changes though. Fixes #1116

@lreading lreading marked this pull request as ready for review December 27, 2024 17:41
@jgadsden jgadsden self-requested a review December 27, 2024 19:48
Copy link
Collaborator

@jgadsden jgadsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the neatest of solutions :)
please go ahead and merge

@lreading lreading merged commit 58e622e into main Dec 27, 2024
10 checks passed
@lreading lreading deleted the chore/express-5-migration branch December 27, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants