Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update image URLs on session fixation page #889

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Update image URLs on session fixation page #889

merged 1 commit into from
Feb 28, 2024

Conversation

njmulsqb
Copy link
Contributor

@njmulsqb njmulsqb commented Feb 20, 2024 •
edited
Loading

related to #888

With 💚 from Tecvity

kingthorin
kingthorin reviewed Feb 20, 2024
View reviewed changes
Copy link
Contributor

@kingthorin kingthorin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you actually intend this to be a fix they should be added to the assets folder and displayed as images not just linked. If that's to tough it's okay someone else can tackle it, just remove the fixes comment from the PR before we merge.

@njmulsqb
Copy link
Contributor Author

Removed the fixes comment

@kingthorin kingthorin self-assigned this Feb 28, 2024
@kingthorin kingthorin merged commit 4da1ff1 into OWASP:master Feb 28, 2024
@kingthorin kingthorin mentioned this pull request Feb 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingthorin kingthorin kingthorin approved these changes

Assignees

@kingthorin kingthorin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njmulsqb @kingthorin