Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feenkcom PythonBridge extensions #10

Open
wants to merge 66 commits into
base: master
Choose a base branch
from
Open

feenkcom PythonBridge extensions #10

wants to merge 66 commits into from

Conversation

akgrant43
Copy link

As discussed:

  • Signal python exceptions in the calling process, not the server process (which effectively locked the image)
  • Don't hang if stdout / stderr subprocess output exceeds buffer size.
  • Allow the runtime files to be easily copied to a separate location (doesn't require git repository to be present, and doesn't modify the git repository; removes the circular symbolic link)
  • Allow the pipenv path and working directory to be specified in the settings. (Especially useful on Mac where there doesn't appear to be a standard python installation).
  • Add support for the DAP debugger
  • Add support for custom proxy classes.
  • Automatically stop the python server on pharo shutdown.
  • Report error information from the subprocess when something goes wrong (not demoed).
  • Fix a few of the automated tests.

akgrant43 and others added 30 commits January 8, 2021 10:25
@akgrant43
Use github://feenkcom/OSSubprocess/repository
f9442e2
@akgrant43
Allow the runtime directory to be used without the repository present.
b47dc56
@akgrant43
Create the symbolic link for the module
f9950f3
@akgrant43
Pass remote exceptions back to the calling process
ce4af54
@akgrant43
Use #isSuccess to check the OS process status in PBPharoPlatform>>for…
4245e1e 
…ceInstallEnvironment
@khinsen
Run installation script with pipenv on PATH
91bc338
@akgrant43
Merge pull request #1 from khinsen/pipenv-on-path
de4e0ca 
Run installation script with pipenv on PATH
@akgrant43
Add pipenvPath and workingDirectory to PBSettings
f2f11cc
@akgrant43
Allow the server installation / working directory to be specified.
39be56b
@akgrant43
PBPharoPlatform handle application directory located in image directory.
06fca29
@akgrant43
Remove unused PBPharoPlatform>>ensureApplicationSymlinks:
2bc0c00
@akgrant43
Use the specified directory when installin the environment in PBPharo…
f97b46a 
…Platform
@akgrant43
Don't rely on the global command factory for every instance of PBAppl…
0be62a6 
…ication
@akgrant43
PBPharoPlatform: copy runtime files keeping file attributes
f793d0a
@akgrant43
PBSettings>>pipenvPath: typo
ac62e12
@akgrant43
PBPharoPipenvProcess>>resolvePipenvPath signalPipenvNotFound fix
be12519
@akgrant43
Pipenv path typo
998547c
@chisandrei
Load the v17 tag for NeoJSON
310b24a
@akgrant43
Deprecation auto-rewrite
b009fea
@akgrant43
Use the pipenvPath specified in settings
bfedd9f
@akgrant43
Enable the pipenvPath and working directory to be set in PBSettings
72b54eb
@akgrant43
Catch primitive errors in #isPythonReady, flag process as stopped in …
57ffa65 
…#stop
@akgrant43
PBPharoPipenvProcess: mark all servers stopped on system startup
badca6b
@chisandrei
Update copy command to not use -r and *
91511e9
@akgrant43
PBPharoPlatform>>copyApplicationTo:application: common copy for Mac a…
7b9702c 
…nd Linux
@akgrant43
PBPharoPlatform: don't create the directory before copying the runtim…
19ee614 
…e files.
@akgrant43
Begin extending PythonBridge to support the DAPDebugger
f3e8843 
DAP = Debug Adapter Protocol
@akgrant43
Initial support for DAPDebugger
27c5416
@akgrant43
DAPDebugger is now abstract, use DAPPythonDebugger
a19938c
@akgrant43
PBObject can be subclassed with proxies that have locally defined vie…
2dd57a5 
…ws and other functionality
akgrant43 and others added 30 commits March 22, 2021 08:50
@akgrant43
Move Gt views to Gt4PythonBridge
83059d4
@akgrant43
Add PythonCommandStringFactory
ba96617
@akgrant43
Quote directory names when installing the runtime to allow spaces in …
df306c7 
…the directory names.
@seandenigris
[Enh]: Start if Needed on uniqueInstance Access
8c040ad
@akgrant43
Merge pull request #3 from seandenigris/enh_start-if-needed
f698e35 
[Enh]: Start if Needed on `uniqueInstance` Access
@akgrant43
Add PBApplication>>installModule:
158c224
@seandenigris
Stop PBApplication on shutdown
487f3e4 
To avoid "bridge not running" when quitting and then restarting an image.
@akgrant43
Merge pull request #4 from seandenigris/enh_stop-on-shutdown
22b6ffe 
Stop PBApplication on shutdown
@akgrant43
Restructure PythonBridge runtime
3b1d3f4 
So that there isn't a circular symbolic link and it is possible to
easily copy just the runtime files without copying the entire git
repository.

Issue: feenkcom/gtoolkit#1936
@akgrant43
Avoid copying the entire disk on Mac when the repository doesn't exist
d629e0c
@akgrant43
Add class variable: RuntimeSourceDirectory
254d6cd 
Allowing the runtime source to be packaged in a custom location.

Issue: feenkcom/gtoolkit#1936
@akgrant43
PBPharoPlatform class>>runtimeSourceDirectory: don't resolve a file l…
20724b7 
…ocator
@akgrant43
Update PBPharoPlatform method comments
dc2c833
@akgrant43
Add PBApplication>>pythonServerStatus
38a5976 
Initial version only reports basic information.  To be enhanced.
@akgrant43
PBApplication>>pythonServerStatusOn: Add stdout and stderr
99cbf34
@akgrant43
Improve error handling to show stdio when something goes wrong.
8468554
@akgrant43
PBPythonProcessError>>printOn: print the message text if set.
ce82f85
@akgrant43
PBApplication>>waitInitialization improve the error information
1250569
@akgrant43
Add PBApplication class>>killAll
51fc1df
@akgrant43
Add killpbserver.sh script
f8ee31a
@akgrant43
PbApplication:>>pythonServerStatusOn:process: add exit status
fb2fe37
@akgrant43
PBPharoPlatform: set the executable bit on shell scripts
3ccfce1
@akgrant43
Modify killpbservers.sh grep expression to something that should work…
29739c9 
… on Mac
@akgrant43
PBSettings add Settings view in inspector
0a79379
@akgrant43
Indicate when the external server executable can't be found
b6ad2bc
@akgrant43
PBMessageBrokerTest fix broken tests
5b2a0d7 
testRMessageWithParams and testRSyncMessage handlers expected a dictionary to be passed, while all other tests expected an association to be passed.    Modify the comparison in those two tests to expect the association for msgpack.
@akgrant43
Add PbPythonError>>summaryText
8fb1989
@akgrant43
Replace GtUnixSubprocess with PBUnixSubprocess to facilitate using Py…
3c5df2c 
…thonBridge in vanilla Pharo images
@akgrant43
BaselineOfPythonBridge: use OSSubprocess from pharo-contributions
4d06d47
@akgrant43
Change OSSubprocess to 'github://feenkcom/OSSubprocess:main/repository'.
2b47fed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akgrant43 @khinsen @chisandrei @seandenigris