Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ModifiedUtf8 for nbt serialization #477

Open
wants to merge 4 commits into
base: 1.21.x
Choose a base branch
from
Open

Add ModifiedUtf8 for nbt serialization #477

wants to merge 4 commits into from

Conversation

Tides
Copy link
Member

@Tides Tides commented Jan 30, 2025

Closes #476

@github-actions github-actions bot added the nbt Relates to Obsidian.Nbt label Jan 30, 2025
Naamloos
Naamloos requested changes Jan 30, 2025
View reviewed changes
Copy link
Member

@Naamloos Naamloos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I'd be willing to merge this if this means the server won't run on hardware that does not support AVX2...

@Naamloos
Copy link
Member

Previous review can be ignored, I did see one place where a check for Avx2 support was missing. If you can add a check and make sure it properly falls back when it's not supported, it should all loog good to me and be ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naamloos Naamloos Naamloos requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
nbt Relates to Obsidian.Nbt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nbt string serialization should use javas modified utf8 format
2 participants
@Tides @Naamloos