-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sediment model fixes + simpler model #121
Conversation
…jsw/instant-remineralisation-sediment
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
+ Coverage 61.90% 63.85% +1.94%
==========================================
Files 27 28 +1
Lines 974 1021 +47
==========================================
+ Hits 603 652 +49
+ Misses 371 369 -2
☔ View full report in Codecov by Sentry. |
I think I will make another PR after this to change flat sediments to actually have flat fields, and to make them work with bathymetry which shouldn't be too hard and just means everytime we index into the |
Co-authored-by: Navid C. Constantinou <[email protected]>
I've finally fixed sediment models so they work properly and conserve nitrogen!
Also fixed a few bugs in the sediment model time-stepping and adds a simple instant remineralization model (as described in PISCESv2 paper).
Hopefully after #120 is merged the odd commit history will be fixed.