Update LAT LON LAT_GPS LON_GPS according to NVS definitions #269
Conversation
vturpin
requested review from
glidermann,
castelao,
justinbuck,
kerfoot,
tcarval,
emmerbodc and
callumrollo
as code owners
OG_Format.adoc
Outdated
| @@ -268,7 +268,7 @@ OG1.0 requirements cover positioning variables and geolocation of any scientific | |||
| * data type: double | |||
| * dimension: N_MEASUREMENTS | | |||
|
|
|||
| * long_name = “longitude of each measurement and GPS location”; | |||
| * long_name = “longitude east”; | |||
There was a problem hiding this comment.
can you add capital 'L' to match vocab description
OG_Format.adoc
Outdated
| @@ -347,8 +347,8 @@ OG1.0 requirements cover the GPS variables delivered by the glider when at the s | |||
| * data type: double | |||
| * dimension: N_MEASUREMENTS | | |||
|
|
|||
| * long_name = “longitude of each GPS location”; | |||
| * standard_name = “longitude”; | |||
| * long_name = “longitude east by unspecified GPS system”; | |||
Replying to Emma's comment
| @@ -268,8 +268,8 @@ OG1.0 requirements cover positioning variables and geolocation of any scientific | |||
| * data type: double | |||
| * dimension: N_MEASUREMENTS | | |||
|
|
|||
| * long_name = “longitude of each measurement and GPS location”; | |||
| * standard_name = “longitude”; | |||
| * long_name = “Longitude east”; | |||
There was a problem hiding this comment.
It is often used only "Longitude" as long_name. Many applications automatically add units right after, so in that case it would result in Longitude east [degrees_east]. But a valid choice if you want that way.
OG_Format.adoc
Outdated
| * long_name = “longitude of each measurement and GPS location”; | ||
| * standard_name = “longitude”; | ||
| * long_name = “Longitude east”; | ||
| * standard_name = “Longitude”; |
There was a problem hiding this comment.
I believe the standard name longitude is defined with all lower case. Look at: http://cfconventions.org/Data/cf-standard-names/current/build/cf-standard-name-table.html
| * long_name = “longitude of each GPS location”; | ||
| * standard_name = “longitude”; | ||
| * long_name = “Longitude east by unspecified GPS system”; | ||
| * standard_name = “GPS fixed longitude”; |
There was a problem hiding this comment.
I don't see GPS fixed longitude in the standard name table. The standard_name requires a valid entry. It is often used longitude (yes, identical to above since they are both longitudes, but different variables). One alternative is to register a new entry in the Standard Names table, it violates the CF rules as proposed.
There was a problem hiding this comment.
shall we leave this blank for now until a new entry is created
There was a problem hiding this comment.
I don't think we need a new entry do we ? I think we just have to align to what exist.
LAT_GPS and LON_GPS are well described in NVS.
The 'concept name' in the nvs is "GPS fixed longitude" and "GPS fixed "latitude". See https://vocab.nerc.ac.uk/collection/OG1/current/LON_GPS/.
Maybe the "concept name" in NVS should not be our standard name. Then what should be our standard_name when the vocab exist ?
Let's use correctly what is available at NVS.
I push this discussion #271, as I think, the issue comes from a bit of unclarity in the use of the content of the NVS.
|
I'll wait this PR to be approved and merged before updating the checker, so I do it only once. |
… definition in the vocab For LAT, LON, LAT_GPS, LON_GPS.
|
This is linked to this PR : nvs-vocabs/OG1#4 Note that I had to push multiple PR related to this issues due to typo. Sorry for that. The latest version follow the above description. If there are any lack of compliance with CF Rule, I suggest, the NVS definition or alt label modified. |
Proponents:
Moderator: @OceanGlidersCommunity/format-mantainers
Type of PR
Related Issues