Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic test #33
Basic test #33
Changes from 12 commits
16159dc
a41afab
dbb7f0d
34a44a7
56f44b5
fd6f84e
17948e1
0a6ab7a
c2bb72f
528d1b3
02ee54d
a694733
635110e
72a83cd
ad173e2
89f88a6
49c7d50
e566bdb
9ad6008
c4d4555
87b040f
3e42563
01ffb83
1e1267f
3b65eca
36ead1b
5186d7e
8bb7ee2
1cf2082
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary? We don't have this in parcels. What does this file do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ran for every test. It chanced the working directory of the test to the directory of the test itself. The reason I did this is because the config json is next to the test, and since the working directory was at the project root I had to type the path to the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this PR, but at some point we should reconsider whether we want to keep using
json
files. We could also move toyaml
-files (with the advantage of allowing comments) or another format?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In plasticparcels, we've started to move to a API that is more like numpy etc, where we use an abbreviation (
vship
?) for all functions. E.g.Should we start doing that here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me. Regarding the API(what is exported where in which modules), I will look at that after I've finished the first cleanup round.
This file was deleted.