Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add timeboost troubleshooting guide #2113
base: master
Are you sure you want to change the base?
add timeboost troubleshooting guide #2113
Changes from 8 commits
980016b
9a1a7d1
d65200b
b62fb11
334fa37
179f432
bd590fd
ff368d7
a0de51a
0d4c777
3028343
aa5456b
7ab3523
880aeea
98d38e1
7e70739
a95d515
9847476
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph seems a bit confusing, since it starts saying that the transaction arrives at
t=0ms
but later say that it takestime_to_arrive
to arrive.I have some extra comments in general about the sequencer behavior explained here, that I'll share on Slack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this sound?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The paragraph is still confusing, at the beginning it says that the transaction arrives at t=0ms (if a transaction arrives at the Sequencer at
t=0ms
) but later says that it takes time_to_arrive to arrive (wheretime_to_arrive
is the time...) 😅Maybe it would be clearer if we say something like "If transaction is sent at t=0ms, and the block is produced at t=250ms, the expected response time is 250ms - time_to_arrive, where
time_to_arrive
is ..."wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see what you're saying, apologies. How's this? Also I think its always going to be 250ms plus time_to_arrive right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, that's less confusing, yeah. But I think the timing is still a bit off. If I send my transaction at t=0ms, and the block is produced at t=250ms, it will be confirmed at t=250ms if
time_to_arrive
is less than 250ms.For example, say that I send at t=0ms, and
time_to_arrive
is 50ms. The transaction will make it to the next block at the t=250ms mark, but the current formula suggests that the expected response time will be50+250ms = 300ms
.If
time_to_arrive
is more than 250ms, then it will make it to the next block. Always assuming that the block is not filled up before.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good - will make a change.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.