responds to pr feedback

OffchainLabs · Nov 30, 2023 · 49e7aea · 49e7aea
1 parent 0b194c2
commit 49e7aea
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 12 deletions.
diff --git a/src/lib/dataEntities/networks.ts b/src/lib/dataEntities/networks.ts
@@ -350,7 +350,12 @@ export const Networks: Record<string, Chain> = {
 }
 
 const isParentChain = (chain: Chain): chain is ParentChain => {
-  return chain && 'partnerChainIDs' in chain
+  return (
+    chain &&
+    'partnerChainIDs' in chain &&
+    !!chain.partnerChainIDs &&
+    chain.partnerChainIDs.length > 0
+  )
 }
 
 const isChildChain = (chain: Chain): chain is ChildChain => {

diff --git a/tests/unit/network.test.ts b/tests/unit/network.test.ts
@@ -11,10 +11,10 @@ describe('Network', () => {
   const fetchErrorMessage =
     'Network fetched successfully but the chain ID is invalid.'
 
-  it('Adds a custom Orbit chain', async function () {
+  it('adds a custom Orbit chain', async function () {
     const arbOneNetwork = await getL2Network(arbOneId)
 
-    addCustomNetwork({
+    const mockCustomNetwork = {
       customL2Network: {
         // we partially copy Arbitrum One network because we only want to mimic a custom chain
         ...arbOneNetwork,
@@ -24,15 +24,19 @@ describe('Network', () => {
         isCustom: true,
         isOrbit: true,
       },
-    })
+    } as const
+
+    addCustomNetwork(mockCustomNetwork)
+
+    expect(await getNetwork(mockOrbitChainId)).to.be.ok
   })
 
-  it('Successfully fetches an L1 network with `getL1Network`', async function () {
+  it('successfully fetches an L1 network with `getL1Network`', async function () {
     const network = await getL1Network(mainnetId)
     expect(network.chainID, fetchErrorMessage).to.be.eq(mainnetId)
   })
 
-  it('Fails to fetch an L2 network with `getL1Network`', async function () {
+  it('fails to fetch an L2 network with `getL1Network`', async function () {
     let network
     try {
       network = await getL1Network(arbOneId)
@@ -48,12 +52,12 @@ describe('Network', () => {
     }
   })
 
-  it('Successfully fetches an L2 network with `getL2Network`', async function () {
+  it('successfully fetches an L2 network with `getL2Network`', async function () {
     const network = await getL2Network(arbOneId)
     expect(network.chainID, fetchErrorMessage).to.be.eq(arbOneId)
   })
 
-  it('Fails to fetch an L1 network with `getL2Network`', async function () {
+  it('fails to fetch an L1 network with `getL2Network`', async function () {
     let network
     try {
       network = await getL2Network(mainnetId)
@@ -69,12 +73,12 @@ describe('Network', () => {
     }
   })
 
-  it('Successfully fetches a parent chain with `getNetwork`', async function () {
+  it('successfully fetches a parent chain with `getNetwork`', async function () {
     const parentChain = await getNetwork(arbOneId)
     expect(parentChain.chainID, fetchErrorMessage).to.be.eq(arbOneId)
   })
 
-  it('Fails to fetch an Orbit chain with `getNetwork`', async function () {
+  it('fails to fetch an Orbit chain with `getNetwork` because it is in the wrong layer', async function () {
     let parentChain
     try {
       parentChain = await getNetwork(mockOrbitChainId, 1)
@@ -90,12 +94,12 @@ describe('Network', () => {
     }
   })
 
-  it('Successfully fetches an Orbit chain with `getNetwork`', async function () {
+  it('successfully fetches an Orbit chain with `getNetwork`', async function () {
     const chain = await getNetwork(mockOrbitChainId)
     expect(chain.chainID, fetchErrorMessage).to.be.eq(mockOrbitChainId)
   })
 
-  it('Fails to fetch a parent chain with `getNetwork`', async function () {
+  it('fails to fetch a parent chain with `getNetwork` because it is the wrong layer', async function () {
     let chain
     try {
       chain = await getNetwork(mainnetId, 2)