feat: add support for custom gas token #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzeoneth
reviewed
Feb 13, 2024
src/lib/assetBridger/erc20Bridger.ts
Outdated
| @@ -696,6 +788,11 @@ export class Erc20Bridger extends AssetBridger< | |||
| // in the future we want to do proper estimation here | |||
| /* eslint-disable @typescript-eslint/no-unused-vars */ | |||
| estimateL1GasLimit: async (l1Provider: Provider) => { | |||
| if (!this.nativeTokenIsEth) { | |||
| // measured 172867 - add some padding | |||
| return BigNumber.from(200000) | |||
There was a problem hiding this comment.
this probably won't work for L3->L2 withdrawal
| @@ -706,7 +803,7 @@ export class Erc20Bridger extends AssetBridger< | |||
| const isWeth = await this.isWethGateway(l1GatewayAddress, l1Provider) | |||
|
|
|||
| // measured 157421 - add some padding | |||
| return isWeth ? BigNumber.from(180000) : BigNumber.from(160000) | |||
| return isWeth ? BigNumber.from(190000) : BigNumber.from(160000) | |||
There was a problem hiding this comment.
this probably won't work for L3->L2 withdrawal
gzeoneth
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
L2Network
nativeTokenAssetBridger
nativeTokennativeTokenIsEthwhich is a boolean that represents whether the Arbitrum chain that is being used with the bridger uses ETH as the native token.EthBridger
Added
getApproveGasTokenRequestandapproveGasTokentoEthBridger, which help approve the custom gas token to be spent by the Inbox. When adding support for a custom gas token chain, the user only needs to call this before doing the regular deposit, while the rest of the flow stays the same. The bridger object will pick between 2 separate code paths depending on the value ofnativeTokenIsEth.These methods will throw if used on a chain that uses ETH as the gas token.
Erc20Bridger
Added
getApproveGasTokenRequestandapproveGasTokentoEthBridger, which help approve the custom gas token to be spent by the appropriate Gateway. When adding support for a custom gas token chain, the user only needs to call this before doing the regular deposit, while the rest of the flow stays the same. The bridger object will pick between 2 separate code paths depending on the value ofnativeTokenIsEth.These methods will throw if used on a chain that uses ETH as the gas token.
L1ToL2MessageCreator
Updated
getTicketCreationRequestto support custom gas token chains and have different calldata in that case.