-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: resolve audit vulnerabilities #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brtkx
commented
Aug 17, 2023
audit-ci.jsonc
Outdated
// _msgSender return address(0) in calls that originate from the forwarder with calldata shorter than 20 bytes | ||
// from: @arbitrum/nitro-contracts>@openzeppelin/contracts-upgradeable | ||
// from @arbitrum/nitro-contracts>@openzeppelin/contracts | ||
// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need some brief explanation why it's safe to ignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are not affected (not using that particular contract) and also it does not affect the sdk anyway
spsjvc
reviewed
Aug 17, 2023
Co-authored-by: spsjvc <[email protected]>
spsjvc
reviewed
Aug 17, 2023
spsjvc
changed the title
fix: resolve audit vulnerabilities
chore: resolve audit vulnerabilities
Aug 17, 2023
spsjvc
approved these changes
Aug 17, 2023
gzeoneth
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.