Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve audit vulnerabilities #322

Merged
merged 3 commits into from
Aug 17, 2023
Merged

chore: resolve audit vulnerabilities #322

merged 3 commits into from
Aug 17, 2023

Conversation

brtkx
Copy link
Contributor

@brtkx brtkx commented Aug 17, 2023

No description provided.

@cla-bot cla-bot bot added the cla-signed label Aug 17, 2023
audit-ci.jsonc Outdated
// _msgSender return address(0) in calls that originate from the forwarder with calldata shorter than 20 bytes
// from: @arbitrum/nitro-contracts>@openzeppelin/contracts-upgradeable
// from @arbitrum/nitro-contracts>@openzeppelin/contracts
//
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need some brief explanation why it's safe to ignore

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are not affected (not using that particular contract) and also it does not affect the sdk anyway

@brtkx brtkx requested review from spsjvc and gzeoneth August 17, 2023 09:49
@brtkx brtkx marked this pull request as ready for review August 17, 2023 09:49
audit-ci.jsonc Outdated Show resolved Hide resolved
audit-ci.jsonc Outdated Show resolved Hide resolved
@spsjvc spsjvc changed the title fix: resolve audit vulnerabilities chore: resolve audit vulnerabilities Aug 17, 2023
@spsjvc spsjvc merged commit 808a05b into main Aug 17, 2023
6 checks passed
@spsjvc spsjvc deleted the fix-audit branch August 17, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants