-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update l1/2 name for dataEntities #340
Changes from all commits
8948983
448b959
8391400
6e77e75
7e23cad
3684f80
6608b97
9c023f2
b3527f3
96e1848
4cb843f
54006a2
908fa85
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,12 +43,12 @@ export { L1ToL2MessageGasEstimator } from './lib/message/L1ToL2MessageGasEstimat | |
export { argSerializerConstructor } from './lib/utils/byte_serialize_params' | ||
export { CallInput, MultiCaller } from './lib/utils/multicall' | ||
export { | ||
L1Networks, | ||
L2Networks, | ||
L1Network, | ||
L2Network, | ||
getL1Network, | ||
getL2Network, | ||
ParentChains as L1Networks, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we also export these parent/child versions? Will we get rid of the old L1Network variant and bump a major? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. All the import/export aliases that are used during this renaming process will eventually be removed. We're using them to reduce the number of changes in each PR. These changes are targeting a major bump release. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There will also be a big file renaming PR at the end. |
||
ChildChains as L2Networks, | ||
ParentChain as L1Network, | ||
ChildChain as L2Network, | ||
getParentChain as getL1Network, | ||
getChildChain as getL2Network, | ||
addCustomNetwork, | ||
addDefaultLocalNetwork, | ||
} from './lib/dataEntities/networks' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the usages of the neworks in the imported files be renamed in a separate pr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes ser