Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: standarderc20 test #367

Merged
merged 3 commits into from
Oct 18, 2023
Merged

fix: standarderc20 test #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4129f1
fix: standarderc20 test
gzeoneth Oct 18, 2023
0944ce0
chore: use latest testnode
gzeoneth Oct 18, 2023
481f606
format: fix
gzeoneth Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ jobs:
uses: OffchainLabs/actions/run-nitro-test-node@main
with:
no-token-bridge: true
nitro-testnode-ref: '520f2589411d76bf2ce740c65658ee81bea433df'

- name: Copy .env
run: cp ./.env-sample ./.env
Expand Down
10 changes: 3 additions & 7 deletions tests/integration/standarderc20.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,13 +210,9 @@ describe('standard ERC20', () => {
])
)

// supply just enough gas to cover l1 costs - this also covers l2 costs since the
// that estimate returns some margin
await redeemAndTest(
waitRes.message,
0,
gasComponents.gasEstimateForL1.sub(200000)
)
// force the redeem to fail by submitted just a bit under the required gas
// so it is enough to pay for L1 + L2 intrinsic gas costs
await redeemAndTest(waitRes.message, 0, gasComponents.gasEstimate.sub(1000))
await redeemAndTest(waitRes.message, 1)
})

Expand Down