Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix warnings for jsdoc comments #518

Merged
merged 3 commits into from
Jul 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions src/lib/assetBridger/erc20Bridger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -899,9 +899,11 @@ export class Erc20Bridger extends AssetBridger<

/**
* Checks if the token has been properly registered on both gateways. Mostly useful for tokens that use a custom gateway.
* @param erc20ParentAddress
* @param parentProvider
* @param childProvider
*
* @param {Object} params
* @param {string} params.erc20ParentAddress
* @param {Provider} params.parentProvider
* @param {Provider} params.childProvider
* @returns
*/
public async isRegistered({
Expand Down Expand Up @@ -1170,9 +1172,9 @@ export class AdminErc20Bridger extends Erc20Bridger {

/**
* Get all the gateway set events on the Parent gateway router
* @param parentProvider
* @param customNetworkParentGatewayRouter
* @returns
* @param parentProvider The provider for the parent network
* @param filter An object containing fromBlock and toBlock to filter events
* @returns An array of GatewaySetEvent event arguments
*/
public async getParentGatewaySetEvents(
parentProvider: Provider,
Expand All @@ -1193,25 +1195,27 @@ export class AdminErc20Bridger extends Erc20Bridger {
}

/**
* Get all the gateway set events on the L2 gateway router
* @param parentProvider
* @param customNetworkParentGatewayRouter
* @returns
* Get all the gateway set events on the child gateway router
* @param childProvider The provider for the child network
* @param filter An object containing fromBlock and toBlock to filter events
* @param customNetworkChildGatewayRouter Optional address of the custom network child gateway router
* @returns An array of GatewaySetEvent event arguments
* @throws {ArbSdkError} If the network is custom and customNetworkChildGatewayRouter is not provided
*/
public async getChildGatewaySetEvents(
childProvider: Provider,
filter: { fromBlock: BlockTag; toBlock: BlockTag },
customNetworkL2GatewayRouter?: string
customNetworkChildGatewayRouter?: string
): Promise<EventArgs<GatewaySetEvent>[]> {
if (this.childNetwork.isCustom && !customNetworkL2GatewayRouter) {
if (this.childNetwork.isCustom && !customNetworkChildGatewayRouter) {
throw new ArbSdkError(
'Must supply customNetworkL2GatewayRouter for custom network '
'Must supply customNetworkChildGatewayRouter for custom network '
)
}
await this.checkChildNetwork(childProvider)

const childGatewayRouterAddress =
customNetworkL2GatewayRouter ||
customNetworkChildGatewayRouter ||
this.childNetwork.tokenBridge.childGatewayRouter

const eventFetcher = new EventFetcher(childProvider)
Expand Down
2 changes: 1 addition & 1 deletion src/lib/inbox/inbox.ts
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ export class InboxTools {
* Sign a transaction with msg.to, msg.value and msg.data.
* You can use this as a helper to call inboxTools.sendChainSignedMessage
* above.
* @param message A signed transaction which can be sent directly to chain,
* @param txRequest A signed transaction which can be sent directly to chain,
* tx.to, tx.data, tx.value must be provided when not contract creation, if
* contractCreation is true, no need provide tx.to. tx.gasPrice and tx.nonce
* can be overrided. (You can also send contract creation transaction by set tx.to
Expand Down
8 changes: 4 additions & 4 deletions src/lib/message/ChildToParentMessage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ export class ChildToParentMessage {
/**
* Instantiates a new `ChildToParentMessageWriter` or `ChildToParentMessageReader` object.
*
* @param {SignerOrProvider} ParentSignerOrProvider Signer or provider to be used for executing or reading the Child-to-Parent message.
* @param {SignerOrProvider} parentSignerOrProvider Signer or provider to be used for executing or reading the Child-to-Parent message.
* @param {ChildToParentTransactionEvent} event The event containing the data of the Child-to-Parent message.
* @param {Provider} [ParentProvider] Optional. Used to override the Provider which is attached to `ParentSignerOrProvider` in case you need more control. This will be a required parameter in a future major version update.
* @param {Provider} [parentProvider] Optional. Used to override the Provider which is attached to `ParentSignerOrProvider` in case you need more control. This will be a required parameter in a future major version update.
*/
public static fromEvent<T extends SignerOrProvider>(
parentSignerOrProvider: T,
Expand Down Expand Up @@ -289,9 +289,9 @@ export class ChildToParentMessageWriter extends ChildToParentMessageReader {
/**
* Instantiates a new `ChildToParentMessageWriter` object.
*
* @param {Signer} ParentSigner The signer to be used for executing the Child-to-Parent message.
* @param {Signer} parentSigner The signer to be used for executing the Child-to-Parent message.
* @param {ChildToParentTransactionEvent} event The event containing the data of the Child-to-Parent message.
* @param {Provider} [ParentProvider] Optional. Used to override the Provider which is attached to `ParentSigner` in case you need more control. This will be a required parameter in a future major version update.
* @param {Provider} [parentProvider] Optional. Used to override the Provider which is attached to `parentSigner` in case you need more control. This will be a required parameter in a future major version update.
*/
constructor(
parentSigner: Signer,
Expand Down
2 changes: 1 addition & 1 deletion src/lib/message/ChildToParentMessageClassic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ export class ChildToParentMessageReaderClassic extends ChildToParentMessageClass
/**
* Get the status of this message
* In order to check if the message has been executed proof info must be provided.
* @param proofInfo
* @param childProvider
* @returns
*/
public async status(
Expand Down
4 changes: 2 additions & 2 deletions src/lib/message/ChildToParentMessageNitro.ts
Original file line number Diff line number Diff line change
Expand Up @@ -524,8 +524,8 @@ export class ChildToParentMessageReaderNitro extends ChildToParentMessageNitro {

/**
* Check whether the provided network has a BoLD rollup
* @param l2Network
* @param l1Provider
* @param arbitrumNetwork
* @param parentProvider
* @returns
*/
private async isBold(
Expand Down
2 changes: 1 addition & 1 deletion src/lib/message/ChildTransaction.ts
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export class ChildTransactionReceipt implements TransactionReceipt {

/**
* Get any child-to-parent-messages created by this transaction
* @param l2SignerOrProvider
* @param parentSignerOrProvider
*/
public async getChildToParentMessages<T extends SignerOrProvider>(
parentSignerOrProvider: T
Expand Down
2 changes: 1 addition & 1 deletion src/lib/message/ParentTransaction.ts
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ export class ParentTransactionReceipt implements TransactionReceipt {

/**
* Get any eth deposit messages created by this transaction
* @param childSignerOrProvider
* @param childProvider
*/
public async getEthDeposits(
childProvider: Provider
Expand Down
Loading