Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix InboxTools method: GetForceIncludableBlockRange #520

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix InboxTools method: GetForceIncludableBlockRange #520

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
22cebbd
fix InboxTools-getForceIncludableBlockRange
FacuDeLorenzo Jul 18, 2024
c82f195
Merge branch 'OffchainLabs:main' into main
FacuDeLorenzo Aug 1, 2024
57f3957
cast on maxTimeVariation call
FacuDeLorenzo Aug 2, 2024
ec20488
fix cast type on maxTimeVariation call
Aug 12, 2024
3a7cb15
fixed own email to commit for CLA
FacuDeLorenzo Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/inbox/inbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,11 +211,11 @@
targetAddr: sequencerInbox.address,
encoder: () =>
sequencerInbox.interface.encodeFunctionData('maxTimeVariation'),
decoder: (returnData: string) =>

Check failure on line 214 in src/lib/inbox/inbox.ts

View workflow job for this annotation

GitHub Actions / Test (Unit) on Node.js v18 

Type '(returnData: string) => Result' is not assignable to type '(returnData: string) => [BigNumber, BigNumber, BigNumber, BigNumber] & { delayBlocks: BigNumber; futureBlocks: BigNumber; delaySeconds: BigNumber; futureSeconds: BigNumber; }'.

Check failure on line 214 in src/lib/inbox/inbox.ts

View workflow job for this annotation

GitHub Actions / Lint on Node.js v18 

Type '(returnData: string) => Result' is not assignable to type '(returnData: string) => [BigNumber, BigNumber, BigNumber, BigNumber] & { delayBlocks: BigNumber; futureBlocks: BigNumber; delaySeconds: BigNumber; futureSeconds: BigNumber; }'.

Check failure on line 214 in src/lib/inbox/inbox.ts

View workflow job for this annotation

GitHub Actions / Test (Unit) on Node.js v20 

Type '(returnData: string) => Result' is not assignable to type '(returnData: string) => [BigNumber, BigNumber, BigNumber, BigNumber] & { delayBlocks: BigNumber; futureBlocks: BigNumber; delaySeconds: BigNumber; futureSeconds: BigNumber; }'.

Check failure on line 214 in src/lib/inbox/inbox.ts

View workflow job for this annotation

GitHub Actions / Test (Integration) on Node.js v18 

Type '(returnData: string) => Result' is not assignable to type '(returnData: string) => [BigNumber, BigNumber, BigNumber, BigNumber] & { delayBlocks: BigNumber; futureBlocks: BigNumber; delaySeconds: BigNumber; futureSeconds: BigNumber; }'.

Check failure on line 214 in src/lib/inbox/inbox.ts

View workflow job for this annotation

GitHub Actions / Lint on Node.js v20 

Type '(returnData: string) => Result' is not assignable to type '(returnData: string) => [BigNumber, BigNumber, BigNumber, BigNumber] & { delayBlocks: BigNumber; futureBlocks: BigNumber; delaySeconds: BigNumber; futureSeconds: BigNumber; }'.

Check failure on line 214 in src/lib/inbox/inbox.ts

View workflow job for this annotation

GitHub Actions / Test (Integration) on Node.js v18 with L3 

Type '(returnData: string) => Result' is not assignable to type '(returnData: string) => [BigNumber, BigNumber, BigNumber, BigNumber] & { delayBlocks: BigNumber; futureBlocks: BigNumber; delaySeconds: BigNumber; futureSeconds: BigNumber; }'.

Check failure on line 214 in src/lib/inbox/inbox.ts

View workflow job for this annotation

GitHub Actions / Test (Integration) on Node.js v20 

Type '(returnData: string) => Result' is not assignable to type '(returnData: string) => [BigNumber, BigNumber, BigNumber, BigNumber] & { delayBlocks: BigNumber; futureBlocks: BigNumber; delaySeconds: BigNumber; futureSeconds: BigNumber; }'.

Check failure on line 214 in src/lib/inbox/inbox.ts

View workflow job for this annotation

GitHub Actions / Test (Integration) on Node.js v20 with L3 

Type '(returnData: string) => Result' is not assignable to type '(returnData: string) => [BigNumber, BigNumber, BigNumber, BigNumber] & { delayBlocks: BigNumber; futureBlocks: BigNumber; delaySeconds: BigNumber; futureSeconds: BigNumber; }'.

Check failure on line 214 in src/lib/inbox/inbox.ts

View workflow job for this annotation

GitHub Actions / Test (Integration) on Node.js v18 with L3 with custom gas token 

Type '(returnData: string) => Result' is not assignable to type '(returnData: string) => [BigNumber, BigNumber, BigNumber, BigNumber] & { delayBlocks: BigNumber; futureBlocks: BigNumber; delaySeconds: BigNumber; futureSeconds: BigNumber; }'.

Check failure on line 214 in src/lib/inbox/inbox.ts

View workflow job for this annotation

GitHub Actions / Test (Integration) on Node.js v20 with L3 with custom gas token 

Type '(returnData: string) => Result' is not assignable to type '(returnData: string) => [BigNumber, BigNumber, BigNumber, BigNumber] & { delayBlocks: BigNumber; futureBlocks: BigNumber; delaySeconds: BigNumber; futureSeconds: BigNumber; }'.
sequencerInbox.interface.decodeFunctionResult(
'maxTimeVariation',
returnData
)[0],
),
},
multicall.getBlockNumberInput(),
multicall.getCurrentBlockTimestampInput(),
Expand Down
Loading