Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: non-18 decimal custom gas token support #530

Merged
merged 176 commits into from
Oct 16, 2024
Merged

feat: non-18 decimal custom gas token support #530

merged 176 commits into from
Oct 16, 2024

Conversation

spsjvc
Copy link
Member

@spsjvc spsjvc commented Aug 28, 2024

No description provided.

@cla-bot cla-bot bot added the cla-signed label Aug 28, 2024
@@ -75,10 +72,6 @@ describe('Custom ERC20', () => {
}
await fundParentSigner(testState.parentSigner)
await fundChildSigner(testState.childSigner)

if (isArbitrumNetworkWithCustomFeeToken()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this, fundParentSigner and fundChildSigner cover this

@spsjvc spsjvc marked this pull request as ready for review October 16, 2024 10:09
@spsjvc spsjvc enabled auto-merge (squash) October 16, 2024 10:09
Copy link
Contributor

@brtkx brtkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of @spsjvc

@spsjvc spsjvc merged commit ab3ec88 into main Oct 16, 2024
19 checks passed
@spsjvc spsjvc deleted the non18-decimal-v4 branch October 16, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants