feat: add Arb Sepolia list #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fionnachan
commented
Dec 20, 2023
| paths: | ||
| - ArbTokenLists/421614_arbed_coinmarketcap.json | ||
| version: true | ||
| command: yarn arbify --l2NetworkID 421614 --ignorePreviousList 421614_arbed_uniswap_labs_default.json --tokenList https://gateway.ipfs.io/ipns/tokens.uniswap.org --newArbifiedList ./src/ArbTokenLists/421614_arbed_uniswap_labs_default.json |
There was a problem hiding this comment.
--ignorePreviousList is temporary because we don't have an existing list yet and the arbifying process won't work without this flag
There was a problem hiding this comment.
Reverted, list was uploaded to s3
fionnachan
commented
Jan 3, 2024
| then | ||
| additionalPath='TestFolder/' | ||
| else | ||
| additionalPath='/' |
There was a problem hiding this comment.
looks like it should be an empty string instead?
There was a problem hiding this comment.
We can do both, have it as TestFolder or empty string. And add the slash where we use it, or have it here, right now we have it as part of the variable (see line 168)
|
@chrstph-dvx LGTM but i can't approve my own PR :D |
chrstph-dvx
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #106