Merge pull request #2633 from OffchainLabs/redis_consumer_fix

Redis consumer fix
OffchainLabs · Sep 5, 2024 · 5828659 · 5828659
2 parents 3e673d4 + 9a9515f
commit 5828659
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/validator/valnode/redis/consumer.go b/validator/valnode/redis/consumer.go
@@ -111,10 +111,12 @@ func (s *ValidationServer) Start(ctx_in context.Context) {
 				req, err := c.Consume(ctx)
 				if err != nil {
 					log.Error("Consuming request", "error", err)
+					requestTokenQueue <- struct{}{}
 					return 0
 				}
 				if req == nil {
-					// There's nothing in the queue.
+					// There's nothing in the queue
+					requestTokenQueue <- struct{}{}
 					return time.Second
 				}
 				select {
@@ -152,9 +154,10 @@ func (s *ValidationServer) Start(ctx_in context.Context) {
 				res, err := valRun.Await(ctx)
 				if err != nil {
 					log.Error("Error validating", "request value", work.req.Value, "error", err)
-				}
-				if err := s.consumers[work.moduleRoot].SetResult(ctx, work.req.ID, res); err != nil {
-					log.Error("Error setting result for request", "id", work.req.ID, "result", res, "error", err)
+				} else {
+					if err := s.consumers[work.moduleRoot].SetResult(ctx, work.req.ID, res); err != nil {
+						log.Error("Error setting result for request", "id", work.req.ID, "result", res, "error", err)
+					}
 				}
 				select {
 				case <-ctx.Done():