Support the Arbitrum BoLD Challenge Protocol in Nitro #2362
+3,646
−625
This pull request is big! We’re only showing the most recent 250 commits.
Commits on Mar 27, 2024
Commits on Mar 28, 2024
-
-
-
-
-
-
-
Merge pull request #2201 from OffchainLabs/overflow-assertions-state-…
…provider Update BOLD state provider for overflow assertions
-
-
-
-
-
-
-
Commits on Mar 31, 2024
Commits on Apr 1, 2024
Commits on Apr 11, 2024
Commits on May 13, 2024
Commits on May 14, 2024
Commits on May 15, 2024
Commits on May 24, 2024
Commits on May 30, 2024
-
-
Merge branch 'sepolia-tooling-merge' of github.com:OffchainLabs/nitro…
… into sepolia-tooling-merge
-
Commits on May 31, 2024
Commits on Jun 6, 2024
Commits on Jun 7, 2024
Commits on Jun 11, 2024
Commits on Jun 12, 2024
Commits on Jun 13, 2024
Commits on Jun 17, 2024
Commits on Jun 21, 2024
Commits on Jun 29, 2024
Commits on Jul 1, 2024
Commits on Jul 8, 2024
Commits on Jul 9, 2024
Commits on Jul 10, 2024
Commits on Jul 12, 2024
Commits on Jul 15, 2024
Commits on Jul 18, 2024
Commits on Aug 6, 2024
-
-
-
-
add dangerous option where validator is nil and node just assumes all…
… blocks are valid
-
-
Commits on Aug 14, 2024
Commits on Aug 29, 2024
Commits on Sep 25, 2024
Commits on Oct 17, 2024
-
-
Update bold to include the history committment optimizations
It is no longer required (or even efficient) for the state provider to be populating all the missing leafs in a virtual tree.
-
Commits on Oct 23, 2024
-
-
Snapshot of trying to get bold tests passing again
This is just a commit on a branch to give Lee a picture of where Pepper was when he stopped trying to get the bold-review branch's tests passing again. Essentially, I think there is at least one (but maybe several) off-by-one issues with the current implementation in the bold_state_provider. I would recommend trying to get the `bold_state_provider_test.go` (specifically, `TestChallengeProtocolBOLD_StateProvider`) to pass before moving to the other tests. I think it is attempting to validate more tightly-scoped behavior than the other tests in this package. BTW, I'm not actually 100% confident that the whole system is wired together correctly before calling the state provider. But, I do believe that errors there are less-likely than in the implementation. In my heart, I think Raul had these tests passing at some point in history. We probably just silently broke them and never noticed. Thanks for looking into this.
Commits on Oct 25, 2024
-
-
Update bold-review to the head of bold/main
This also adjusts all the imports to use the lowercase offchainlabs.
-
-
-
Get's the bold_state_provider_test.go tests passing
The big problem is still the end-to-end TestChallengeProtocolBOLD test.
-
Commits on Oct 28, 2024
-
Now that the virtual padding is handled in the BoLD protocol itself and not in the creation of the hash leaves being fed into the history committer, the number of hashes read from the cache doesn't need to equal the number of leaves (including virtual leaves.)
-
Commits on Oct 31, 2024
-
-
Update the pin for the bold submodule
This is the current unify-req-meta branch which fixes a bug in one-step proof calculation.
Commits on Nov 1, 2024
-
This *should* be able to wrap an arbitrator machine and do the special handling for the BoLD protocol to make it look like there is one more machine state at the front of processing a machine.
-
Fix the two obviously errored hasStepped bits
This still doesn't get the test passing, but it's bound to be closer.
Commits on Nov 2, 2024
Commits on Nov 4, 2024
-
-
Attempt at fixing the virtual leaves issue
The CollectProof and CollectMachineHashes functions were both susceptible to challenges where it was possible that the rival would have committed to more messages than this validator. And, in that case, it would attempt to look up a message number which was greater than the highest messge number it had verified as part of the batch in which the challenge originated.
Commits on Nov 5, 2024
-
-
Merge pull request #2769 from OffchainLabs/bold-start-step-test
Bold start step test
-
-
Handle challenges in the virtually padded part of the leaaves
Before this change, if there was a block challenge at a height in any block above the batchLimit, then the validator was not correctly creating inclusion proofs because it was attempting to fetch execution results for blocks which didn't really exist. Now, the code detects that situation and simply returns the hash of an arbitrator machine in the FINISHED state (since the Virtual leaf hashes) are all in that state by virtue of their being repeated copies of the end state of a block.
Commits on Nov 6, 2024
Commits on Nov 7, 2024
-
Fix the CollectProof and CollectMachineHashes calls
Previously, they couldn't produce correct inclusion proofs for block-level challenges on blocks in the virtual range. That is to say, if this validaotor processed n L2Blocks when creating an assertion and a rival processed >= n+1 L2Blocks, this validator would attempt to lookup a block index for which no real block existed. Now, the code properly catches this case and the last machine state for the last real block is used for all virtual L2Blocks.
Commits on Nov 12, 2024
-
This is probably not where we ultimately want to be. Too much boilerplate is escaping from the bold system. Maybe, before introducing a dependency injection framework, I should just introduce something manual that would instatiate all the instances that the challenge manager, watcher, assertion manager, etc. need and then wires them together in the "default" way using the constructors from each package.
Commits on Nov 14, 2024
Commits on Nov 18, 2024
-
-
-
Update to the same go-ethereum pin as master
This version of the go-ethereum project is needed for some of the tests to behave correctly.
-
Commits on Nov 19, 2024
-
-
The first is to sort the imports in mock_machine_test.go. The second is to rearrange the bold machine to avoid the downcast.
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.