-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to brotli v1.1.0 #2625
base: master
Are you sure you want to change the base?
Update to brotli v1.1.0 #2625
Conversation
The previous pin was almost 3 years old, and was causing some ugly warnings during builds. This change also deals with google/brotli@641bec0 which stopped creating the static libraries by default and switched to only building them with `-DBUILD_SHARED_LIBS=OFF`. Also, now that the static libraries are unambiguous, the `-static` suffix was removed from the library names.
I was a bit worried at first because brotli up to v1.0.5 kept improving the compression, which would be a breaking consensus chain because we measure how large compressed txs are to charge for them. But it seems like since then compression has been stable, so this should work in theory. I don't think we should include it in v3.1.2 though, and I think we should look at doing more specialized testing such as rerunning it against the Arbitrum One chain history to make sure this doesn't change behavior. |
I'd be happy to run it against the Arbitrum One chain history to make sure that this doesn't change behavior. The first thing that comes to my mind is:
Is that the idea, or did you have a different process in mind? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2625 +/- ##
==========================================
- Coverage 23.07% 22.96% -0.12%
==========================================
Files 260 260
Lines 37719 37719
==========================================
- Hits 8704 8662 -42
- Misses 27571 27607 +36
- Partials 1444 1450 +6 |
specifically, what we want to know is that brotli compression level 1 did not change. |
The previous pin was almost 3 years old, and was causing some ugly warnings during builds.
This change also deals with google/brotli@641bec0 which stopped creating the static libraries by default and switched to only building them with
-DBUILD_SHARED_LIBS=OFF
.Also, now that the static libraries are unambiguous, the
-static
suffix was removed from the library names.