Test precompile methods related to stylus #2737
Conversation
cla-bot
bot
added
the
s
system_tests/program_test.go
Outdated
| ensure(arbDebug.BecomeChainOwner(&ownerAuth)) | ||
|
|
||
| // ArbOwner precompile methods | ||
| testConst := uint16(10) |
There was a problem hiding this comment.
This is probably going to sound paranoid, but I'd use different values for each different thing you want to test.
As an example, suppose there were a broken implementation of: SetInkPrice and SetWasmInitCostScalar
And actually, the broken implementation meant that whatever value gets passed to SetInkPrice actually sets the value for WasmInitCostScalar and vice versa. Your test would still pass, but there would be a serious bug in the behavior.
There was a problem hiding this comment.
I agree, specially considering that today there are different precompile functions, even from different precompiles, that have the same side effect.
Not sure if that is the case of the functions tested in this PR though, but it would be a good practice anyway.
There was a problem hiding this comment.
I agree. Fixed it
system_tests/program_test.go
Outdated
| ensure(arbDebug.BecomeChainOwner(&ownerAuth)) | ||
|
|
||
| // ArbOwner precompile methods | ||
| testConst := uint16(10) |
There was a problem hiding this comment.
I agree, specially considering that today there are different precompile functions, even from different precompiles, that have the same side effect.
Not sure if that is the case of the functions tested in this PR though, but it would be a good practice anyway.
Following precompile methods are tested-
ArbWasmCache precompile methods,
-total methods = 6,
-already tested methods elsewhere = 5 -> "AllCacheManagers", "CacheProgram", "CodehashIsCached", "IsCacheManager", "EvictCodehash"
-deprecated methods = 1 -> CacheCodehash
ArbOwner precompile methods,
-total methods = 12,
-already tested methods elsewhere = 2 -> "RemoveWasmCacheManager", "AddWasmCacheManager"
-number of methods tested here = 10
ArbWasm precompile methods,
-total methods = 20
-already tested methods elsewhere = 5 -> "CodehashVersion", "ProgramInitGas", "ProgramMemoryFootprint", "ProgramVersion", "StylusVersion"
-number of methods tested here = 15