Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NIT-2845] Add a nitro option to stop syncing at a given block number #2749

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[NIT-2845] Add a nitro option to stop syncing at a given block number #2749

wants to merge 10 commits into from
+114 −30

Conversation

amsanghi
Copy link
Contributor

Fixes: NIT-2845

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Oct 22, 2024
@amsanghi amsanghi marked this pull request as ready for review October 22, 2024 14:54
@codecov Codecov
Copy link

codecov bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.37190% with 54 lines in your changes missing coverage. Please review.

Project coverage is 23.21%. Comparing base (d3fa9a7) to head (8a13df5).
Report is 95 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2749      +/-   ##
==========================================
+ Coverage   23.18%   23.21%   +0.02%     
==========================================
  Files         262      262              
  Lines       37977    38061      +84     
==========================================
+ Hits         8806     8836      +30     
- Misses      27719    27766      +47     
- Partials     1452     1459       +7

tsahee
tsahee requested changes Oct 30, 2024
View reviewed changes
arbnode/delayed_sequencer.go Outdated Show resolved Hide resolved
arbnode/delayed_sequencer.go Outdated Show resolved Hide resolved
arbnode/inbox_reader.go Outdated Show resolved Hide resolved
arbnode/node.go Outdated Show resolved Hide resolved
arbnode/seq_coordinator.go Show resolved Hide resolved
arbnode/transaction_streamer.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsahee tsahee Awaiting requested review from tsahee

@joshuacolvin0 joshuacolvin0 Awaiting requested review from joshuacolvin0

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amsanghi @joshuacolvin0 @tsahee