Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated deep-link creation logic in tab-request-approval. #1402

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pankajmunde12
Copy link
Contributor

@pankajmunde12 pankajmunde12 commented Sep 29, 2024

Hi @VaraPrasad-MSFT @Pawank-MSFT
I figured out that in tab-request-approval app, the logic that creates a deep link for activity notification, was using "installation-id". But as per the Microsoft documentation, we need to use the app-id in the deep-link.
Also, the property 'teamsApp' needs to be replaced with 'teamsAppDefinition'. (Kindly check the changes in Files-Changed section of this PR.

Please refer to this article by the Microsoft:
https://learn.microsoft.com/en-us/microsoftteams/platform/concepts/build-and-test/deep-link-application?tabs=teamsjs-v2#configure-deep-link-to-browse-within-your-app-manually

After this change I am able to view the request details when I click on the activity notification in Teams.

The link generated by the old logic:
https://teams.microsoft.com/l/entity/**NWNjMTM0YzYtMjZjYy00MTY3LWI2NmItM2MwOWFhMzUwYjFlIyMxLjAuMCMjUHVibGlzaGVk**/request?context={"subEntityId":"8afee96e-b5cf-4afe-9534-fbf1f7fc2dbf"}

The link generated by the new logic:
https://teams.microsoft.com/l/entity/**4d2f0656-0c42-4c76-8f18-3796f4c37f0f**/request?context={"subEntityId":"21281529-4ce7-41f4-a906-8d87e40b3632"}

tab-request-approval-notification

MS Teams Article

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant