Updated deep-link creation logic in tab-request-approval. #1402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @VaraPrasad-MSFT @Pawank-MSFT
I figured out that in tab-request-approval app, the logic that creates a deep link for activity notification, was using "installation-id". But as per the Microsoft documentation, we need to use the app-id in the deep-link.
Also, the property 'teamsApp' needs to be replaced with 'teamsAppDefinition'. (Kindly check the changes in Files-Changed section of this PR.
Please refer to this article by the Microsoft:
https://learn.microsoft.com/en-us/microsoftteams/platform/concepts/build-and-test/deep-link-application?tabs=teamsjs-v2#configure-deep-link-to-browse-within-your-app-manually
After this change I am able to view the request details when I click on the activity notification in Teams.
The link generated by the old logic:
https://teams.microsoft.com/l/entity/**NWNjMTM0YzYtMjZjYy00MTY3LWI2NmItM2MwOWFhMzUwYjFlIyMxLjAuMCMjUHVibGlzaGVk**/request?context={"subEntityId":"8afee96e-b5cf-4afe-9534-fbf1f7fc2dbf"}
The link generated by the new logic:
https://teams.microsoft.com/l/entity/**4d2f0656-0c42-4c76-8f18-3796f4c37f0f**/request?context={"subEntityId":"21281529-4ce7-41f4-a906-8d87e40b3632"}