Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors #159

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Refactors #159

merged 5 commits into from
Oct 29, 2024

Conversation

elliot-100
Copy link
Collaborator

@elliot-100 elliot-100 commented Oct 21, 2024 •
edited
Loading

This PR makes some refactors for simplification/maintainability:

  • extract some constants to non-public class constants
  • mark DT_FORMAT class constant as non-public
  • extract 'base event' template to non-public module
  • extract Spond._match_person() from repeated code in Spond.get_person()
  • remove unnecessary elif after return statement
  • remove unnecessary assignment before return statement

I will leave it open for a while in case anyone has comments.

@elliot-100 elliot-100 marked this pull request as draft October 21, 2024 11:05
@elliot-100 elliot-100 marked this pull request as ready for review October 21, 2024 11:09
@elliot-100 elliot-100 marked this pull request as draft October 21, 2024 13:00
@elliot-100 elliot-100 force-pushed the refactors branch 3 times, most recently from bab4a71 to 6d827c5 Compare October 22, 2024 10:19
@elliot-100 elliot-100 self-assigned this Oct 22, 2024
@elliot-100 elliot-100 added the enhancement New feature or request label Oct 22, 2024
@elliot-100 elliot-100 marked this pull request as ready for review October 22, 2024 10:22
@elliot-100 elliot-100 merged commit 4766ca8 into Olen:main Oct 29, 2024
5 checks passed
@elliot-100 elliot-100 deleted the refactors branch October 29, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@elliot-100 elliot-100

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@elliot-100