Skip to content

Commit

Permalink
Rectifying and enhancing incorrect comment WRT "Icon:" tag
Browse files Browse the repository at this point in the history
No icon *path*, just a pure basename makes sense in the SOURCE directory, because dirname of the icon path is always stripped by `rpmbuild`.
  • Loading branch information
Olf0 authored Aug 31, 2020
1 parent 9148291 commit d90f55d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions rpm/sfos-upgrade.spec
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ License: MIT
URL: https://github.com/Olf0/%{name}
Source: https://github.com/Olf0/%{name}/archive/%{version}/%{name}-%{version}.tar.gz
# rpmbuild (as of v4.14.1) handles the Icon tag awkwardly and in contrast to the Source tag(s):
# It only accepts a file path to a GIF or XPM file (successfully tested GIF89a and XPMv3) rooted
# in the SOURCE directory (but not in the tarball)!
# It only accepts a GIF or XPM file (successfully tested GIF89a and XPMv3, but an XPM icon results
# in a bad visual quality and large file size) in the SOURCE directory (but not in the tarball)!
# Hence only to be used, when the file is put there:
# Icon: up.256x256.gif
BuildArch: noarch
Expand Down

0 comments on commit d90f55d

Please sign in to comment.