Convert extract tests, fix test setup #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, minor fix up to follow https://lunarmodules.github.io/busted/. |
|
Nice! Thank you very much for this. I will probably try to recover that buffer helpers module, I think it gets used in a few places so it'll be worth converting that too. Thank you for helping out 🎉 |
|
Oh after re-reading I realise that it was a one off and see why you
integrated it. Oh well, we have a generic test util module now for the
future if required.
…On Mon, 19 Aug 2024, 10:23 Russ Tokuyama, ***@***.***> wrote:
Sorry, minor fix up to follow https://lunarmodules.github.io/busted/.
—
Reply to this email directly, view it on GitHub
<#595 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACM6XIT7MQT5Y5DAQJV6JDZSG2P3AVCNFSM6AAAAABMXMHJWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJWGA4TAOJUGI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first try at converting an Aniseed test to busted + luassert.
I picked one that required a supporting test module that appears to be a one-off thing. I hope the integration of that module is OK. fennel code formatting might be a bit messed up by my Neovim set up. Advice and corrections are more than welcome.