-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Settings #14
base: main
Are you sure you want to change the base?
Add Settings #14
Conversation
added new screenshots
I'll look into it, the The relative positions isn't stored anywhere which is a bit of an oversight but we can just store it in localstorage and use that on load. The performance I don't really know but when I look at it now it definitely is lower than usual. I'll try to see if I can find the issue. Edit: Actually, the performance is completely fine for me, i checked on firefox and chrome again and it was running even better on firefox than chrome. So I don't really know if I can look into it that well. |
Every time we resize the screen or stop dragging the minimap we save the relative position to localstorage and then load it on load.
Both of these issues came from the Restrict Minimap to Graph since it only works with the beta menu. I changed it so it is a beta setting and mentioned that it only works with the beta menu in the tooltip. The setting doesn't do anything if the beta menu is disabled anymore. And although I agree that "Restrict Minimap to Graph" isn't exactly the greatest name I don't know if "keep minimap under UI" is right either since the setting forces the minimap to be inside the content area not exactly below the UI. But I can't really think of anything better myself so that's really up to you. |
Since we can't know if the beta menu setting is changed easily, now we just check if the padding is larger or equal to the size of comfy and if it is then return 0 padding. This also stops the issue as far as I can tell while also staying responsive if you decide to change the menu. Also just a nice safeguard to have if something goes wrong with the padding for whatever reason. |
Add several settings to help users customize their experience, I tried to make it simple to add new settings. Changing a setting triggers a custom event so that we don't have to check for changes every time we want to use a setting, the event is also triggered on startup to initialize the values.
Settings