Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network bug: connections not removed #328

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions extensions/olcPGEX_Network.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@

Author
~~~~~~
David Barr, aka javidx9, OneLoneCoder 2019, 2020, 2021
David Barr, aka javidx9, ©OneLoneCoder 2019, 2020, 2021

*/

Expand Down Expand Up @@ -922,12 +922,12 @@ namespace olc
// be tracking it somehow
OnClientDisconnect(client);

// Off you go now, bye bye!
client.reset();

// Then physically remove it from the container
m_deqConnections.erase(
std::remove(m_deqConnections.begin(), m_deqConnections.end(), client), m_deqConnections.end());

// Off you go now, bye bye!
client.reset();
}
}

Expand Down