Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase user-model/main into main #702

Merged
merged 267 commits into from
Mar 8, 2024
Merged

Rebase user-model/main into main #702

merged 267 commits into from
Mar 8, 2024

Conversation

jinliu9508
Copy link
Contributor

@jinliu9508 jinliu9508 commented Feb 26, 2024

This PR rebase user-model/main into main.
Note that user-model/main-rebased is a rebased version of user-model/main.


This change is Reviewable

@jinliu9508 jinliu9508 force-pushed the user-model/main-rebased branch 7 times, most recently from f7ef17d to a3095e8 Compare February 27, 2024 22:25
@jinliu9508 jinliu9508 changed the title WIP - User model/main rebased Rebase user-model/main into main Feb 27, 2024
@jinliu9508 jinliu9508 force-pushed the user-model/main-rebased branch from a3095e8 to 31b57c1 Compare February 27, 2024 22:30
Copy link
Contributor

@shepherd-l shepherd-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@jinliu9508 jinliu9508 force-pushed the user-model/main-rebased branch 4 times, most recently from a3095e8 to 1d91296 Compare March 4, 2024 18:57
shepherd-l and others added 17 commits March 4, 2024 14:01
[Feature] Update native OneSignal SDKs dependencies to 5.1.x
Fixes crash on iOS when calling OneSignal.User.PushSubscription.Id or OneSignal.User.PushSubscription.Token when vales are null. strdup only accounts for string parameters and not null
[Feature]Update OneSignal Android SDK dependency to 5.1.2
[Fix] iOS Null PushSubscription Id and Token crash
Add getters and watchers for oneSignalId and externalId
Make OneSignalId and ExternalId nullable for Android
Update Android dependency version to 5.1.5
@jinliu9508 jinliu9508 force-pushed the user-model/main-rebased branch from 1d91296 to 9edbd24 Compare March 4, 2024 19:02
@jinliu9508 jinliu9508 requested a review from shepherd-l March 4, 2024 19:07
@jinliu9508 jinliu9508 force-pushed the user-model/main-rebased branch from 0d9fa37 to 2ba435f Compare March 6, 2024 19:12
@jinliu9508 jinliu9508 requested a review from shepherd-l March 6, 2024 19:13
@jinliu9508 jinliu9508 force-pushed the user-model/main-rebased branch from 2ba435f to ebbd8e8 Compare March 7, 2024 16:03
@jinliu9508 jinliu9508 requested a review from shepherd-l March 7, 2024 16:03
@jinliu9508 jinliu9508 force-pushed the user-model/main-rebased branch from ebbd8e8 to 18e1b6d Compare March 7, 2024 16:15
Copy link
Contributor

@shepherd-l shepherd-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!
Tested OneSignal initialization on an emulated Pixel 4 with Android 12 and physical iPhone 12 with iOS 15.5 built with Unity 2022.3.10f1 with the OneSignal example app

@jinliu9508 jinliu9508 merged commit 494d0a4 into main Mar 8, 2024
1 check passed
@jinliu9508 jinliu9508 deleted the user-model/main-rebased branch March 8, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants