-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase user-model/main into main #702
Conversation
f7ef17d
to
a3095e8
Compare
a3095e8
to
31b57c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
a3095e8
to
1d91296
Compare
[Feature] Update native OneSignal SDKs dependencies to 5.1.x
Fixes crash on iOS when calling OneSignal.User.PushSubscription.Id or OneSignal.User.PushSubscription.Token when vales are null. strdup only accounts for string parameters and not null
[Feature]Update OneSignal Android SDK dependency to 5.1.2
Release/5.0.6
[Fix] iOS Null PushSubscription Id and Token crash
Add getters and watchers for oneSignalId and externalId
Make OneSignalId and ExternalId nullable for Android
Update Android dependency version to 5.1.5
Release/5.1.0
1d91296
to
9edbd24
Compare
0d9fa37
to
2ba435f
Compare
2ba435f
to
ebbd8e8
Compare
ebbd8e8
to
18e1b6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Tested OneSignal initialization on an emulated Pixel 4 with Android 12 and physical iPhone 12 with iOS 15.5 built with Unity 2022.3.10f1 with the OneSignal example app
This PR rebase user-model/main into main.
Note that user-model/main-rebased is a rebased version of user-model/main.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)