Test Reviewer customisation with a private github app #4
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,10 +21,17 @@ jobs: | |
| review: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Generate installation token | ||
| id: generate-token | ||
| uses: tibdex/github-app-token@v1 | ||
| with: | ||
| app_id: 800935 | ||
| private_key: ${{ secrets.CODE_REVIEW_APP_PRIVATE_KEY }} | ||
| installation_id: 46310774 | ||
| - name: AI PR Reviewer | ||
|
Comment on lines
+24
to
31
There was a problem hiding this comment.
This hunk introduces a new step to generate an installation token using the The new step passes essential parameters such as the app ID, private key, and installation ID to the 24: - name: Generate installation token
25: id: generate-token
26: uses: tibdex/github-app-token@v1
27: with:
28: app_id: 800935
29: private_key: ${{ secrets.CODE_REVIEW_APP_PRIVATE_KEY }}
30: installation_id: 46310774
31: - name: AI PR Reviewer
32: uses: Onigam/[email protected]
33: env:
34: GITHUB_TOKEN: ${{ steps.generate-token.outputs.token }} |
||
| uses: Onigam/[email protected] | ||
| env: | ||
| GITHUB_TOKEN: ${{ steps.generate-token.outputs.token }} | ||
Onigam marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| OPENAI_API_KEY: ${{ secrets.MISTRAL_API_KEY }} | ||
| with: | ||
| debug: false | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -66,8 +66,7 @@ export class Commenter { | |
| tag = COMMENT_TAG | ||
| } | ||
|
|
||
| const body = ` | ||
| ${message} | ||
|
|
||
| ${tag}` | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coderabbitai write me a summary of this pull request here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Onigam Here's the summary for the pull request:
This pull request introduces changes to the
.github/workflows/ai-pr-review.ymlfile, enhancing security and maintainability. A new step has been added to generate an installation token using thetibdex/github-app-tokenaction. This token is then utilized in theAI PR Reviewerstep as theGITHUB_TOKEN, replacing the usage of theGITHUB_TOKEN.Additionally, the
src/commenter.tsfile has been updated to modify theCommenterclass. The construction of a comment's body has been altered using a template literal, improving readability and maintainability.These changes improve the security of the codebase by replacing the
GITHUB_TOKENwith a generated token. The modifications insrc/commenter.tslead to more readable and maintainable code.For further information, please refer to the detailed summary provided in the PR description.
Best,
coderabbitai