Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Reviewer customisation with a private github app #4

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Test Reviewer customisation with a private github app #4

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
409c505
ci: activate ai pr reviews
Jan 19, 2024
22c672e
chore: added a custom app as review author
Jan 19, 2024
8db68b0
Merge branch 'main' into ci/darwig-app-as-reviewer
Jan 19, 2024
1d1066f
chore: remove coderabbit comment greeting
Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/ai-pr-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,17 @@ jobs:
review:
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coderabbitai write me a summary of this pull request here

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

@Onigam Here's the summary for the pull request:

This pull request introduces changes to the .github/workflows/ai-pr-review.yml file, enhancing security and maintainability. A new step has been added to generate an installation token using the tibdex/github-app-token action. This token is then utilized in the AI PR Reviewer step as the GITHUB_TOKEN, replacing the usage of the GITHUB_TOKEN.

Additionally, the src/commenter.ts file has been updated to modify the Commenter class. The construction of a comment's body has been altered using a template literal, improving readability and maintainability.

These changes improve the security of the codebase by replacing the GITHUB_TOKEN with a generated token. The modifications in src/commenter.ts lead to more readable and maintainable code.

For further information, please refer to the detailed summary provided in the PR description.

Best,
coderabbitai

runs-on: ubuntu-latest
steps:
- name: Generate installation token
id: generate-token
uses: tibdex/github-app-token@v1
with:
app_id: 800935
private_key: ${{ secrets.DARWIG_PRIVATE_KEY }}
installation_id: 46310774
- name: AI PR Reviewer
uses: Onigam/[email protected]
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ steps.generate-token.outputs.token }}
Onigam marked this conversation as resolved.
Show resolved Hide resolved
OPENAI_API_KEY: ${{ secrets.MISTRAL_API_KEY }}
with:
debug: false
Expand Down