Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH actions #83

Merged
merged 15 commits into from
May 6, 2024
Merged

GH actions #83

merged 15 commits into from
May 6, 2024

Conversation

lbluque
Copy link
Collaborator

@lbluque lbluque commented Apr 11, 2024

No description provided.

@lbluque lbluque marked this pull request as draft April 11, 2024 22:52
@lbluque lbluque changed the title Gh actions GH actions Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.49%. Comparing base (353ec8a) to head (702c236).
Report is 1 commits behind head on main.

❗ Current head 702c236 differs from pull request most recent head 228f4a4. Consider uploading reports for the commit 228f4a4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   88.49%   88.49%           
=======================================
  Files           6        6           
  Lines         565      565           
=======================================
  Hits          500      500           
  Misses         65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lbluque
Copy link
Collaborator Author

lbluque commented Apr 25, 2024

Breaking test is what @misko found and reported to pymatgen materialsproject/pymatgen#3747

So this is not on our end. I can mark the test xfail or use both 14 and 15 as valid answers for now.

@lbluque lbluque marked this pull request as ready for review April 25, 2024 21:05
@lbluque lbluque requested a review from mshuaibii April 26, 2024 16:29
@lbluque
Copy link
Collaborator Author

lbluque commented Apr 26, 2024

This is ready @mshuaibii. To remove CircleCi builds, I think you need to click stop building the project settings - I don't have the option to do it myself.

@misko misko merged commit a01911e into main May 6, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants