64 add support for setting a custom lst source image collection in from landsat c2 sr and from image id methods #67
Conversation
lst_source_list = ['c2_corr', 'c2', 'low_latency'] 'low latency' being the new option from Martha's group. lst is then based off that. c2_corr is default and results in: lst = openet.core.common.landsat_c2_sr_lst_correct(sr_image, landsat.ndvi(prep_image))
lst_source_list = ['c2_corr', 'c2', 'low_latency'] 'low latency' being the new option from Martha's group. lst is then based off that. c2_corr is default and results in: lst = openet.core.common.landsat_c2_sr_lst_correct(sr_image, landsat.ndvi(prep_image))
Added a few more checks on the lst_source value, added an entry in the Image class docstring, and added code to apply a default scale_factor if one is not set.
Started adding support for falling back on the input LST image if the LST source image does not exist, but ended up not implementing this (for now). If the user is expecting to use the LST source, it seems better to fail instead of returning an estimate based on the input LST, but that is not ideal when mapping over a collection. We might want to instead set the LST to a masked image or something so nothing is computed but an image is generated.
|
Made some small changes and minor code cleanup, otherwise it seems pretty good. I did add initial support for using the input LST image as a fallback if the scene is not in the LST source collection, but the more I thought about it I'm not sure that is a great idea. It seems like if a users sets the LST source parameter they are expecting to use those scenes and probably those scenes only. The other thing we could do would be to just use/return a fully masked LST image if there is not one in the LST source collection so that the function still returns an image and will work when mapped over a collection. This is something we should talk about a little more though. |
Adding lst_source_id to generic image properties dictionary
|
Noting that this PR includes code to use a fully masked image for LST if there is not one available in the source collection. |
gabe-parrish
deleted the
64-add-support-for-setting-a-custom-lst-source-image-collection-in-from_landsat_c2_sr-and-from_image_id-methods
branch
No description provided.