Moved Tcorr water masking code to a dedicated function #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed "water_mask" to "not_water_mask" so that pixels with a value of 1 are not-water (or land) and pixels with a value of 0 are water.
|
@gabe-parrish Can I go ahead and merge this into main? The code is functionally the same with this change and I'm not seeing any differences in the test images that I have generated so far. |
|
@cgmorton, if we revert, for any reason, will the old branch be 'resuscitated' for lack of a better word? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed naming of the mask and function to be "not_water", with mask values of 1 indicating pixels that are not-water (or land) and pixels values of 0 indicating water. This was done so that the masks could be passed directly to the .updateMask() calls in the Tcorr FANO calculation, since updateMask() will keep pixel values of 1 and set pixels of 0 to nodata, and the purpose for these masks is to according to Gabe "get water out of the Tcorr FANO calculation".