-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zynq: Remove support for Zynq-7000 SoC #303
Conversation
ac34e59
to
723156a
Compare
@tnmysh please add a section to top level README for deprecated platforms, add zynq-7000 to it and list the last version with support. Have you looked at the CI failure? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add readme section as described in PR comment.
Fix or explain CI failure
I haven't started reviews on this yet. I am yet to send notification on mailing lists about deprecation of zynq7000. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go.
@rajimoha Could you rebase on latest tip of tree? Also, Please add deprecated platforms related information in README file here: |
@wmamills I think #307 is needed, for CI to pass for this PR. Zephyr failure, is probably not done by this PR. Do you have any opinion if we should merge this PR before #307 ? Also, There is same PR in open-amp repo that remove zynq-7000 support. That should be merged first, and after that this change should be merged. |
This is not really true. Please remove this from commit message. Zynq7000 platform is suported, only open-amp stack will be discontinued. |
rebasing on the main branch should solve the CI issue since the PR #306 has been merged |
Remove support for Zynq-7000 SoC, changes are 1. Remove Zynq7 tool chain support 2. Makefile changes to remove zynq7 Reasons to remove: 1. Removing redundant or unmaintained code 2. Reduce technical debt carried by OpenAMP team 3. very few customer using openamp on Zynq-7000 SoC For using Zynq-7000 SoC support last working and tested version is (v2023.04) https://github.com/OpenAMP/libmetal/tree/v2023.04 Signed-off-by: Rajiv Mohan <[email protected]> Signed-off-by: Tanmay Shah <[email protected]>
723156a
to
9d8b903
Compare
Done. |
@wmamills anything further in this request |
I think this PR can be merged. |
Remove support for Zynq-7000 SoC, changes are
Reasons to remove:
For using Zynq-7000 SoC support last working and tested version is (v2023.10)
https://github.com/OpenAMP/libmetal/tree/v2023.10