-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JAVA] [Jersey3] Make Jakarta Annotation API optional #20576
base: master
Are you sure you want to change the base?
[JAVA] [Jersey3] Make Jakarta Annotation API optional #20576
Conversation
thanks for the PR cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08) |
@@ -92,6 +92,7 @@ These options may be applied as additional-properties (cli) or configOptions (pl | |||
|useBeanValidation|Use BeanValidation API annotations| |false| | |||
|useEnumCaseInsensitive|Use `equalsIgnoreCase` when String for enum comparison| |false| | |||
|useGzipFeature|Send gzip-encoded requests| |false| | |||
|useJakartaAnnotation|Use Jakarta Annotation API| |false| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if useJakartaEe
is set to false (by default), shall it skip the Jakarta annotation by default?
(in other words, do we need another option or we can "reuse" useJakartaEe
in this use case to skip the annotation?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point however, this might be confusing. useJakartaEe
is a flag to decide whether to use Jakarta EE namespace instead of javax
, while the goal of this PR is to allow skipping the jakarta-annotation-api
without using instead the corresponding javax
option.
Allow to skip the generation of the
jakarta-annotation-api
annotations.Fix #20575
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@wing328