Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] feat: source add build field #280

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

myml
Copy link
Collaborator

@myml myml commented Mar 14, 2024

为source添加build字段,可以单独构建每个source

支持挂载构建帮助脚本到容器中

Log:
为source添加build字段,可以单独构建每个source

Log:
@deepin-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myml
Once this PR has been reviewed and has the lgtm label, please assign black-desk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@myml myml marked this pull request as draft March 15, 2024 01:47
@myml myml changed the title feat: source add build field [Draft] feat: source add build field Mar 15, 2024
@deepin-bot
Copy link

deepin-bot bot commented May 13, 2024

TAG Bot

New tag: 1.5.0-1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #372

@deepin-bot
Copy link

deepin-bot bot commented May 14, 2024

TAG Bot

New tag: 1.5.1-1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #421

@deepin-ci-robot
Copy link
Collaborator

deepin pr auto review

关键摘要:

  • LinglongBuilder::buildStageSource函数中,新增了挂载和处理远程source的逻辑,需要确认是否与现有功能兼容。
  • SourceFetcher类中增加了对git类型source的版本号的处理,确保版本号的正确性。
  • 删除了extractLayer函数的实现,可能影响依赖此函数的功能,需要检查是否有替代实现或此功能是否不再需要。
  • 修改了Project::generateBuildScript函数,添加了source的build命令,需要验证新的build命令格式是否正确,并确保与构建系统的集成。

是否建议立即修改:

  • 是,需要确保新增的代码与现有功能兼容,并且不会引入新的bug。同时,需要检查是否有必要的错误处理和日志记录机制。

@deepin-bot
Copy link

deepin-bot bot commented Jun 25, 2024

TAG Bot

New tag: 1.5.6-1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants