Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing XSearch unit tests #1154

Closed
clintonlunn opened this issue Jun 29, 2024 · 3 comments · Fixed by #1155
Closed

Failing XSearch unit tests #1154

clintonlunn opened this issue Jun 29, 2024 · 3 comments · Fixed by #1155

Comments

@clintonlunn
Copy link
Collaborator

There is a failing unit test that was caused by (#1152) (XSearch Change) by removing the searchPoi. The XSearch test is still expecting that geocoderLookupFn call to happen.

Screenshots

image

Expected Behavior

Tests pass after removing geocoderLookupFn expect

Current Behavior

Failing unit test because geocoderlookup is nonexistent anymore

@clintonlunn
Copy link
Collaborator Author

I created this issue thinking it was just the failing tests (everything else passes locally, unit tests and build)...but I can't seem to get the build to pass once I push it to remote. @vnugent do you have any ideas of what could cause a failed build even if both unit tests and build passes locally?

@vnugent
Copy link
Contributor

vnugent commented Jul 3, 2024

I think the failure was due to the staging API server timing out. I've been trying to reduce our server expenses by switching to smaller VMs which caused some recent outages.

@clintonlunn
Copy link
Collaborator Author

@vnugent That makes sense! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants