Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove geocoderLookupFn expect because doesn't happen anymore #1155

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

clintonlunn
Copy link
Collaborator

@clintonlunn clintonlunn commented Jun 29, 2024


name: Pull request
about: Create a pull request
title: ''
labels: ''
assignees: ''


What type of PR is this?(check all applicable)

  • refactor
  • feature
  • bug fix
  • documentation
  • optimization
  • other

Description

Related Issues

Issue #1154

What this PR achieves

I removed the geocoderLookupFn conditions in the XSearch unit tests because that functionality was removed and searchPoi deprecated.

Screenshots, recordings

Notes

Copy link

vercel bot commented Jun 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
open-tacos ✅ Ready (Inspect) Visit Preview Jul 3, 2024 3:07am

@clintonlunn clintonlunn linked an issue Jun 29, 2024 that may be closed by this pull request
@clintonlunn clintonlunn requested review from vnugent and removed request for vnugent June 29, 2024 21:52
@vnugent vnugent merged commit eb0bee4 into develop Jul 3, 2024
6 of 8 checks passed
@vnugent vnugent deleted the xsearch-unit-test branch July 3, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing XSearch unit tests
2 participants