fix: make fullName/display name an empty string if null #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
small bug fix. I defaulted the display name in the title to be an empty string, but the bug ticket indicates that it should instead be the username. Do you have a preference? i.e. |
|
Also, the wording was weird when the user had 0 photos uploaded, I fixed the grammar for that. Instead of saying. "Photo on OpenBeta" it now says "0 Photos on OpenBeta"
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull request
about: Create a pull request
title: ''
labels: ''
assignees: ''
What type of PR is this?(check all applicable)
Description
If a user created an account, set a username but not a display name, the display name (fullName) would be
null. To prevent this, we can use a nullish coalesce operator to check for null and convert to an empty string.NOTE: this did not happen if the user set a display name and then deleted it. In that case, the display name would already be an empty string, not reverted back to null.
Related Issues
Issue #1160
What this PR achieves
Prevent the user from seeing
nullin the tab title. Instead of null, it will become an empty string.Screenshots, recordings
(staging env without change)
(local env with change)
Notes