feat: Improve settings #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Coverage SummaryResults for commit: 88387f8 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Totto16
force-pushed
the
improve_settings
branch
4 times, most recently
from
eb7fa0e
to
64b9cd4
Compare
move the api client to the application, to be able to share it
…verage for sdl_key
move it to the first place in the threaded Initializers of the application, so that everyone after that can use the settings
so that pressing backspace (delete) gets used by the textinput, if necessary and not by the window
also provide a delete + Shift key combination, so that you can delete only the same characters, add ICU for better unicode support, but thats optional, otherwise some ascii functions are used
also use SecretStorage to store and retrieve the token from a secret os dependent store
only implemented linux for now, as this is all very heavily OS dependent
also add break to the switch, where I forgot them
…where this is still WIP
this uses a json file to store the needed keys, it's not as safe as other implementations, but ist works at least
…L2 so import name
deal with annoying windows types and wstrings
…'t use a string without manual conversion
also add some asserts in static layout generation
…it wasn't the correct one for an object, it would use an array, so now it always uses an object
Totto16
force-pushed
the
improve_settings
branch
from
bdb5454
to
dd58ba8
Compare
Totto16
force-pushed
the
improve_settings
branch
from
609f211
to
88387f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.