Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenCTIApiClient parameter types #744

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

OBarronCS
Copy link

Proposed changes

The OpenCTIApiClient class constructor has some parameters that are internally passed to the Python requests libraries functions. ssl_verify is passed to the verify parameter of request of self.session.get and self.session.post. This PR corrects the type hint for ssl_verify - previously it was bool, however it can also be a str ("path to a CA_BUNDLE file or directory with certificates of trusted CAs"). It also provides type hints for the other untyped parameters.

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case - it's just a type hint, don't know if a test is relevant
  • I added/update the relevant documentation (either on github or on notion) - edited the inline doc string
  • Where necessary I refactored code to improve the overall quality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant