Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/ fix points redemption validation to prevent overspending #245

Conversation

LuuNa-JD
Copy link

@LuuNa-JD LuuNa-JD commented Nov 6, 2024

This PR addresses a bug that allowed clubs to redeem more points than they had available, which led to negative point balances. With this fix:

  • A validation check now ensures that clubs cannot book more places than their available points.
  • An error message is displayed to the user if they try to redeem more points than they have, and the booking process is halted.
  • Tests have been added to confirm that the validation logic works as expected, preventing overspending.

Linked Issue: #2

@LuuNa-JD LuuNa-JD changed the title Fix points redemption validation to prevent overspending Bug/ fix points redemption validation to prevent overspending Nov 13, 2024
@LuuNa-JD LuuNa-JD closed this Nov 14, 2024
@LuuNa-JD LuuNa-JD deleted the fix-redeem-points-validation-clean branch November 14, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant