Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiagnosticPublisher drops messages #334

Open
pavel-kirienko opened this issue Apr 21, 2024 · 0 comments
Open

DiagnosticPublisher drops messages #334

pavel-kirienko opened this issue Apr 21, 2024 · 0 comments

Comments

@pavel-kirienko
Copy link
Member

This logic causes messages that follow back-to-back to be dropped:

# Further, unconditionally drop all messages while publishing is in progress for the same reason.
# This logic may need to be reviewed later.
if self._fut is not None and self._fut.done():
self._fut.result()
self._fut = None
dcs_rec = DiagnosticPublisher.log_record_to_diagnostic_message(record, self._forward_timestamp)
if self._fut is None:
self._fut = asyncio.ensure_future(self._publish(dcs_rec))
else:
# DROPPED
pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant