Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cyphal/UDP: the default value of local_node_id should be absent, not zero #323

Open
pavel-kirienko opened this issue Jan 12, 2024 · 0 comments · May be fixed by #337
Open

Cyphal/UDP: the default value of local_node_id should be absent, not zero #323

pavel-kirienko opened this issue Jan 12, 2024 · 0 comments · May be fixed by #337
Assignees
@songmeo
Labels
class-defect domain-transport-udp help wanted severity-minor

Comments

@pavel-kirienko
Copy link
Member

pycyphal/pycyphal/transport/udp/_udp.py

Line 67 in 088932f

local_node_id: typing.Optional[int] = 0,

@pavel-kirienko pavel-kirienko changed the title Cyphal/UDP: the default value of local_node_id should be None, not zero Cyphal/UDP: the default value of local_node_id should be absent, not zero Jan 18, 2024
pavel-kirienko added a commit that referenced this issue Jan 18, 2024
@pavel-kirienko
Fix #323
3e37516
Zaynulla pushed a commit to Zaynulla/pycyphal that referenced this issue Apr 14, 2024
@pavel-kirienko @Zaynulla
Fix OpenCyphal#323
1acc929
songmeo added a commit that referenced this issue May 3, 2024
@songmeo
#323: change local_node_id from 0 to none
80cd896
songmeo added a commit that referenced this issue May 3, 2024
@songmeo
#323: change local_node_id from 0 to none
6e3b2bc
songmeo added a commit to songmeo/pycyphal that referenced this issue May 3, 2024
@songmeo
OpenCyphal#323: change local_node_id from 0 to None
f1ff897
@songmeo songmeo linked a pull request May 3, 2024 that will close this issue
Open
@pavel-kirienko pavel-kirienko linked a pull request May 3, 2024 that will close this issue
Cyphal/UDP: remove the default local_node_id #337
Open
songmeo added a commit to songmeo/pycyphal that referenced this issue May 3, 2024
@songmeo
OpenCyphal#323: change local_node_id from 0 to absent
4ead82c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@songmeo songmeo

Labels
class-defect domain-transport-udp help wanted severity-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cyphal/UDP: remove the default local_node_id songmeo/pycyphal
2 participants
@pavel-kirienko @songmeo