Implementation of grid CO2 traffic light component #2793
Conversation
|
Hi, thanks for your Contribution but could you maybe please follow the Coding Guidelines - especially running the "prepare-commit.sh" ? :) Also in my Opinion we already have it here: Greetings! |
| import java.time.temporal.ChronoUnit; | ||
| import java.io.BufferedReader; | ||
| import java.io.InputStreamReader; | ||
| import java.net.HttpURLConnection; |
There was a problem hiding this comment.
We have a "HttpBridge" for this i guess
There was a problem hiding this comment.
Hi Sn0wy, thanks for your review and your comments!
As I understood it, the HttpBridge is executed every cycle. Since the data is only updated every hour, the https request is currently only executed every hour. Did I get it wrong?
There was a problem hiding this comment.
True, you still could implement a Counter for the requests :)
There was a problem hiding this comment.
Sorry I guess i can't follow. Could you please explain it a bit more? So you mean using the httpBridge.subscribeJsonEveryCycle(); function and adding a counter its passed BiConsumer?
| return new GridEmissionInformation(dateTime, consAdvice, co2); | ||
| } | ||
|
|
||
| private void updateDataBuffer() { |
There was a problem hiding this comment.
The current error handling logs exceptions but still continues execution. For example, if updateDataBuffer() encounters an error, it falls back to using stale data. While this prevents crashes, implementing a retry mechanism or a fallback to a cached version could improve reliability.
There was a problem hiding this comment.
Good point. Currently it uses data from the buffer in case of error and retries in the next hour. If that is not good enough I will add functionality to retry multiple times.
There was a problem hiding this comment.
So if it fails 4 Times in 4 hours one an hour it uses 4 hour old data? :)
There was a problem hiding this comment.
That would be right. But I changed it now so that it retries every 5 minutes if an error occures. Otherwise it waits for
|
|
||
| private final Logger log = LoggerFactory.getLogger(GreenConsumptionAdvisorImpl.class); | ||
|
|
||
| private static final String URL_API_RECOMMONDATION = "https://api.corrently.io/v2.0/gsi/advisor?zip="; |
There was a problem hiding this comment.
The method name writeRecommondationToChannel contains a typo ("Recommondation" should be "Recommendation")
| super.activate(context, config.id(), config.alias(), config.enabled()); | ||
|
|
||
| // TODO validate zip code | ||
| this.urlString = URL_API_RECOMMONDATION + config.zip_code(); |
There was a problem hiding this comment.
The method name writeRecommondationToChannel contains a typo ("Recommondation" should be "Recommendation")
| this.timeNextActualization = LocalDateTime.now().truncatedTo(ChronoUnit.HOURS).plusHours(1); | ||
| } | ||
| this.evaluateDataBuffer(); | ||
| this.writeRecommondationToChannel(); |
There was a problem hiding this comment.
The method name writeRecommondationToChannel contains a typo ("Recommondation" should be "Recommendation")
Hi Sn0wy, thanks for the review! This code also was coded during the Hackathon. The similar merge reqeust contains excample code for an extended Getting started documentation but it does not contain the data buffering logic. Regards! |
…y 5 minutes, if the update fails
This components implements a "traffic light" of the current CO2 emissions fo energy taken from the grid. The CO2 emission data is taken from corrently-api. The traffic light states "Green", "Yellow" and "Red" as well as the CO2 emissions are written to channels of the actual hour.