Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: templateFiles as dict instead of individual parameters insetTemplateFilename #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ombahiwal
Copy link

@ombahiwal ombahiwal commented Jan 24, 2025

from list of issues #17

  • Issue: Pass all the template files in a dictionary instead of all of them individually like here.

Changes:

  • The function setTemplateFilename now takes a single templateFiles dictionary as an argument, where keys are the names of the expected filenames (like EDfilename, SEDfilename, etc.) and values are the actual filenames (e.g., 'EDtemplate', 'SEDtemplate', etc.).
  • The function loops over the templateFiles dict. For each key-value pair, it processes the file similarly to how it did for individual parameters before, checking the filename extension and constructing the file path.
  • By using a dict, you can easily add or remove template files without changing the function signature or adding new parameters. It's now easier to modify and extend the template setup.

@ombahiwal
Copy link
Author

@rthedin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant