Skip to content

Commit

Permalink
Recommend FULL logging level when using SLF4J (#1146)
Browse files Browse the repository at this point in the history
Fixes #1142 

Using the logger without setting the correct logging level results in no logging at all.
  • Loading branch information
dnsbtchr authored and kdavisk6 committed Dec 30, 2019
1 parent e94f9c2 commit 23191e5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,7 @@ public class Example {
public static void main(String[] args) {
GitHub github = Feign.builder()
.logger(new Slf4jLogger())
.logLevel(Level.FULL)
.target(GitHub.class, "https://api.github.com");
}
}
Expand Down
1 change: 1 addition & 0 deletions slf4j/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@ To use SLF4J with Feign, add both the SLF4J module and an SLF4J binding of your
```java
GitHub github = Feign.builder()
.logger(new Slf4jLogger())
.logLevel(Level.FULL)
.target(GitHub.class, "https://api.github.com");
```

0 comments on commit 23191e5

Please sign in to comment.